Skip to content

Fix dxc version printing to fix external validator testing #8075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tex3d wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix dxc version printing to fix external validator testing #8075

tex3d wants to merge 6 commits into from
+113 −85

Conversation

@tex3d
Copy link
Contributor

@tex3d tex3d commented Jan 17, 2026 •
edited
Loading

Version print didn't reveal details from available version interfaces, nor did it print file version for DXIL.dll when available.

Changes:

  • Clean up code a bit
  • No longer skip QI for IDxcVersionInfo2 based on build, since that's for implementer, not user.
  • Print CustomVersionString from IDxcVersionInfo3 if available.
  • Remove ifdefs for WIN32 around file/product version calls, because that's handled in the function.
  • Only print product version string if available for dxil.dll, since that's what it does for dxcompiler.dll.
  • Removes old dev build detection (separate commit in PR so it's easy to reverse if desired)
  • Fixes unconditional print of '(dev' as if it's an old dev build on non-Win32 targets
  • Implement IDxcVersionInfo(2,3) in the IDxcCompiler wrapper interface, so it doesn't look like version 1.0
  • Only print version information for external validator when selected
  • Otherwise, don't print info for a validator we found that won't be used
  • Fix dxc version parsing in lit.cfg
  • Skip LitDXILValidation tests when testing compiler output using released validators

tex3d added 5 commits January 16, 2026 17:56
@tex3d
Improve dxc version printing
9602e5c 
- No longer skip QI for IDxcVersionInfo2 based on build, since that's for implementer, not user.
- Print CustomVersionString from IDxcVersionInfo3 if available.
- Remove ifdefs for _WIN32 around file/product version calls, because that's handled in the function.
- Only print product version string if available for dxil.dll, since that's what it does for dxcompiler.dll.
@tex3d
Remove IsOldDevBuild handling
93ba012 
I don't think this is necessary anymore.
@tex3d
DxCompiler wrapper: Implement IDxcVersionInfo(2,3)
b13e250
@tex3d
Fix dxil validator version printing and parsing for tests
0a19646 
No point printing some dxil module version if not used.

Print it when you set the env var, in which case, the full DXIL path would be printed, so it needs to be less strict about what's immediately before the dxil.dll/libdxil.so name.
@tex3d
Merge branch 'fix-wrapped-dxcompiler-version' into dxc-version-print
15e2689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

HLSL Roadmap
Status: New

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tex3d